fix: Updated Transformer.#visit to skip visiting VariableDeclarator nodes#55
Open
bizob2828 wants to merge 1 commit intonodejs:mainfrom
Open
fix: Updated Transformer.#visit to skip visiting VariableDeclarator nodes#55bizob2828 wants to merge 1 commit intonodejs:mainfrom
Transformer.#visit to skip visiting VariableDeclarator nodes#55bizob2828 wants to merge 1 commit intonodejs:mainfrom
Conversation
Qard
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I reviewed #41. I ran our integration test suite at newrelic to verify feature parity between rust and the new js version. At that time we hadn't migrated grpc-js. Since the rewrite was merged, we did migrate grpc-js to use orchestrion. It turns out it has some interesting syntax that was handled with the rust version and not in the js.
There was more to it but that's the part of the AST that it couldn't locate
registerand wrap it. This PR fixes it