Skip to content

fix: Updated Transformer.#visit to skip visiting VariableDeclarator nodes#55

Open
bizob2828 wants to merge 1 commit intonodejs:mainfrom
bizob2828:iife-class-method
Open

fix: Updated Transformer.#visit to skip visiting VariableDeclarator nodes#55
bizob2828 wants to merge 1 commit intonodejs:mainfrom
bizob2828:iife-class-method

Conversation

@bizob2828
Copy link
Copy Markdown
Contributor

@bizob2828 bizob2828 commented Mar 27, 2026

When I reviewed #41. I ran our integration test suite at newrelic to verify feature parity between rust and the new js version. At that time we hadn't migrated grpc-js. Since the rewrite was merged, we did migrate grpc-js to use orchestrion. It turns out it has some interesting syntax that was handled with the rust version and not in the js.

let Server = (() => {
  class Server {
    register() {}
  }
  return Server
}()

exports.Server = Server

There was more to it but that's the part of the AST that it couldn't locate register and wrap it. This PR fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants