-
-
Notifications
You must be signed in to change notification settings - Fork 6
Add incident report for April 1st #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avivkeller
wants to merge
14
commits into
nodejs:main
Choose a base branch
from
avivkeller:patch-13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−0
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e4f5ca6
Add incident report for March 31, 2025
avivkeller 1f701aa
add root cause
avivkeller ea19655
Update and rename 2026-03-31.md to 2026-04-01.md
avivkeller a36ec13
fixup!
avivkeller 4c745a3
Update incidents/2026-04-01.md
avivkeller ee8d5e0
Update incidents/2026-04-01.md
avivkeller bfd2f35
Update incidents/2026-04-01.md
avivkeller 0743036
typo fix
avivkeller d37fe88
Apply suggestions from code review
avivkeller 68ffb85
Update 2026-04-01.md
avivkeller 647385e
Update 2026-04-01.md
avivkeller a7e8610
Update 2026-04-01.md
avivkeller 549e0e5
Update 2026-04-01.md
avivkeller f1f4a2d
Update 2026-04-01.md
avivkeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # 2026-04-01 Incident Report | ||
|
|
||
| - Incident Commander: @MattIPv4 | ||
| - Severity Level: P2 | ||
|
|
||
| For a brief period of time, the `/en/download/current` page was blank due to a logic bug in determining the Current version of Node.js. The main `/en/download` page was unaffected and could be accessed throughout. | ||
|
|
||
| ## Timeline | ||
|
|
||
| - **2025-04-01 12:00 AM UTC**: Start of impact. Release schedule indicates that Node.js 25.x has moved from Current to Maintenance LTS. | ||
|
|
||
| - **2025-04-01 00:14 AM UTC**: Impact identified by [@MattIPv4's monitoring action](https://github.com/MattIPv4/monitors/actions/runs/23825485542). | ||
|
|
||
| - **2025-04-01 00:51 AM UTC**: Impact reported in [OpenJSF Slack](https://openjs-foundation.slack.com/archives/CVAMEJ4UV/p1775004674164609). Investigation began. | ||
|
|
||
| - **2025-04-01 01:00 AM UTC**: Root cause identified. | ||
|
|
||
| - **2025-04-01 01:20 AM UTC**: [nodejs/nodejs.org#8787](https://github.com/nodejs/nodejs.org/issues/8787) opened to resolve issue. | ||
|
|
||
| - **2025-04-01 01:33 AM UTC**: [nodejs/nodejs.org#8787](https://github.com/nodejs/nodejs.org/issues/8787) merged. Impact resolved shortly after. | ||
|
|
||
| ## Impact | ||
|
|
||
| Users navigating to `https://nodejs.org/en/download/current` would see a blank page instead of the proper download instructions. | ||
|
|
||
| Users accessing any page on the website would see only the 24.x LTS release in the footer, no Current release. | ||
|
|
||
| `https://nodejs.org/en/download` showed 25.x as an LTS release, but was otherwise unaffected by this issue, with users being able to access download instructions as normal. | ||
|
|
||
| On both the `/en/download` page, and throughout the site in the footer, 24.x continued to be shown as the LTS release, due to it still being the Active LTS major, with 25.x having transitioned directly to Maintenance LTS in the schedule. | ||
|
|
||
| ## Root Cause | ||
|
|
||
| According to the static release schedule, on April 1st, 2026, Node.js 25.x was expected to move from Current to Maintenance LTS. Due to this, the website logic automatically started treating 25.x as an Active LTS major. | ||
|
|
||
| However, no new release of 25.x has yet been made to be marked as LTS, nor has the first release of 26.x been made to become the new Current major. This left the website with no Current release per its logic. | ||
|
|
||
| ## Fix | ||
|
|
||
| [nodejs/nodejs.org#8787](https://github.com/nodejs/nodejs.org/issues/8787) resolved the issue by changing the detection of a release's `status` to require `.lts.isLts` to be `true` before allowing a release to be marked as `Active LTS` or `Maintenance LTS`, ensuring that a given major has a valid LTS release available before the website considers it an LTS release. | ||
|
|
||
| ## Follow-up Work | ||
|
|
||
| * When possible, avoid relying on [the expected schedule](https://raw.githubusercontent.com/nodejs/Release/main/schedule.json), as various | ||
| delays and circumstances cause this to be inaccurate to actual release dates. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.