Skip to content

Add retrying execution strategy in tests #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Mar 31, 2026
Merged

Add retrying execution strategy in tests #3799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/EFCore.PG.FunctionalTests/TestUtilities/NpgsqlDbContextOptionsBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ public static NpgsqlDbContextOptionsBuilder ApplyConfiguration(this NpgsqlDbCont
{
optionsBuilder.UseQuerySplittingBehavior(QuerySplittingBehavior.SingleQuery);

optionsBuilder.ExecutionStrategy(d => new TestNpgsqlRetryingExecutionStrategy(d));
Copy link

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestNpgsqlRetryingExecutionStrategy uses NpgsqlRetryingExecutionStrategy defaults (6 retries with exponential backoff; the base class remarks indicate ~1 minute worst-case before failing). Enabling this globally for all functional tests can significantly lengthen feedback loops on deterministic failures that are classified transient (notably the added XX000 SQLSTATE). Consider configuring a smaller retry count / max delay for the test-wide strategy, or only enabling the retrying strategy in the specific tests/fixtures that need it to avoid long hangs on genuine failures.

Copilot uses AI. Check for mistakes.

optionsBuilder.CommandTimeout(NpgsqlTestStore.CommandTimeout);

return optionsBuilder;
Expand Down
Loading