-
-
Notifications
You must be signed in to change notification settings - Fork 334
feat(ui): show maintainers avatars #2055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bluwy
wants to merge
6
commits into
npmx-dev:main
Choose a base branch
from
bluwy:show-maintainer-avatar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−13
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ceb93aa
feat(ui): show maintainers avatars
bluwy d2744e7
revert: stick with same size for now
bluwy ba54e09
fix: only implement known sizes
bluwy 4260601
chore: fix test
bluwy 6c29051
fix: set aria-hidden=true
bluwy 1d310bf
test: add test for sizes
bluwy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,36 @@ | ||
| <script setup lang="ts"> | ||
| const props = defineProps<{ | ||
| username: string | ||
| size: 'xs' | 'lg' | ||
| }>() | ||
|
|
||
| const sizePixels = computed(() => { | ||
| switch (props.size) { | ||
| case 'xs': | ||
| return 24 | ||
| case 'lg': | ||
| return 64 | ||
| } | ||
| }) | ||
|
|
||
| const sizeClass = computed(() => { | ||
| switch (props.size) { | ||
| case 'xs': | ||
| return 'size-6' | ||
| case 'lg': | ||
| return 'size-16' | ||
| } | ||
| }) | ||
|
|
||
| const textClass = computed(() => { | ||
| switch (props.size) { | ||
| case 'xs': | ||
| return 'text-xs' | ||
| case 'lg': | ||
| return 'text-2xl' | ||
| } | ||
| }) | ||
|
|
||
| const { data: gravatarUrl } = useLazyFetch(() => `/api/gravatar/${props.username}`, { | ||
| transform: res => (res.hash ? `/_avatar/${res.hash}?s=128&d=404` : null), | ||
| getCachedData(key, nuxtApp) { | ||
|
|
@@ -14,7 +42,8 @@ const { data: gravatarUrl } = useLazyFetch(() => `/api/gravatar/${props.username | |
| <template> | ||
| <!-- Avatar --> | ||
| <div | ||
| class="size-16 shrink-0 rounded-full bg-bg-muted border border-border flex items-center justify-center overflow-hidden" | ||
| class="shrink-0 rounded-full bg-bg-muted border border-border flex items-center justify-center overflow-hidden" | ||
| :class="sizeClass" | ||
| role="img" | ||
| :aria-label="`Avatar for ${username}`" | ||
| > | ||
|
|
@@ -23,13 +52,22 @@ const { data: gravatarUrl } = useLazyFetch(() => `/api/gravatar/${props.username | |
| v-if="gravatarUrl" | ||
| :src="gravatarUrl" | ||
| alt="" | ||
| width="64" | ||
| height="64" | ||
| :width="sizePixels" | ||
| :height="sizePixels" | ||
| class="w-full h-full object-cover" | ||
| /> | ||
| <!-- Else fallback to initials --> | ||
| <span v-else class="text-2xl text-fg-subtle font-mono" aria-hidden="true"> | ||
| {{ username.charAt(0).toUpperCase() }} | ||
| </span> | ||
| <!-- Else fallback to initials (use svg to avoid underline styling) --> | ||
| <svg | ||
|
Comment on lines
+59
to
+60
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I couldn't figure out how to remove the underline style if wrapped in an anchor tag, so I used an SVG here. Seems like you need |
||
| v-else | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| :width="sizePixels" | ||
| :height="sizePixels" | ||
| class="text-fg-subtle" | ||
| :class="textClass" | ||
| > | ||
| <text x="50%" y="50%" dominant-baseline="central" text-anchor="middle" fill="currentColor"> | ||
| {{ username.charAt(0).toUpperCase() }} | ||
| </text> | ||
| </svg> | ||
| </div> | ||
| </template> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.