Skip to content

fix: avoid using slash as a separator between two numbers#2087

Open
serhalp wants to merge 1 commit intomainfrom
serhalp/size-separator
Open

fix: avoid using slash as a separator between two numbers#2087
serhalp wants to merge 1 commit intomainfrom
serhalp/size-separator

Conversation

@serhalp
Copy link
Member

@serhalp serhalp commented Mar 15, 2026

🔗 Linked issue

N/A

🧭 Context

Screenshot 2026-03-15 at 10 22 33

A slash between numbers implies some sort of fraction or ratio. It isn't intuitive what it means between two dependency counts and between sizes.

This has been bugging me the whole time tbh 😁. I've seen feedback on bsky about this as well, where users didn't know what this information meant (even though there's a tooltip...).

📚 Description

Use parens instead for the total number of transitive deps and for the total install size:

Screenshot 2026-03-15 at 10 42 27

@vercel
Copy link

vercel bot commented Mar 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Mar 15, 2026 2:39pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Mar 15, 2026 2:39pm
npmx-lunaria Ignored Ignored Mar 15, 2026 2:39pm

Request Review

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/pages/package/[[org]]/[name].vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

A slash between numbers implies some sort of fraction or ratio. It isn't
intuitive what it means between two dependency counts and between sizes.
@serhalp serhalp force-pushed the serhalp/size-separator branch from acd8ad6 to 6a17ce3 Compare March 15, 2026 14:37
@serhalp serhalp marked this pull request as ready for review March 15, 2026 14:43
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

📝 Walkthrough

Walkthrough

This PR modifies the package page component to adjust how transitive dependencies and install sizes are displayed. Instead of using a "/" separator, total counts are now wrapped in parentheses. When totals are loading, a spinner appears within the parentheses. If data is unavailable, a dash wrapped in parentheses displays instead. These formatting changes apply to both the transitive dependencies section and the install size section.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the motivation (slash notation is confusing) and describes the change (replacing slashes with parentheses for displaying dependency counts and install sizes).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch serhalp/size-separator
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a8dfb435-eb76-40e1-903f-47aac8143612

📥 Commits

Reviewing files that changed from the base of the PR and between 4422cba and 6a17ce3.

📒 Files selected for processing (1)
  • app/pages/package/[[org]]/[name].vue

Comment on lines +664 to +669
<span v-else-if="installSize?.totalSize" dir="ltr">
<span class="text-fg-subtle">(</span
>{{ bytesFormatter.format(installSize.totalSize)
}}<span class="text-fg-subtle">)</span>
</span>
<span v-else class="text-fg-subtle">(-)</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Handle zero-byte totals explicitly in the install-size branch.

At Line 664, v-else-if="installSize?.totalSize" treats 0 as falsy, so a valid zero total falls through to (-). Use an explicit nullish check.

Suggested fix
-                    <span v-else-if="installSize?.totalSize" dir="ltr">
+                    <span
+                      v-else-if="
+                        installSize?.totalSize !== null &&
+                        installSize?.totalSize !== undefined
+                      "
+                      dir="ltr"
+                    >
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<span v-else-if="installSize?.totalSize" dir="ltr">
<span class="text-fg-subtle">(</span
>{{ bytesFormatter.format(installSize.totalSize)
}}<span class="text-fg-subtle">)</span>
</span>
<span v-else class="text-fg-subtle">(-)</span>
<span
v-else-if="
installSize?.totalSize !== null &&
installSize?.totalSize !== undefined
"
dir="ltr"
>
<span class="text-fg-subtle">(</span
>{{ bytesFormatter.format(installSize.totalSize)
}}<span class="text-fg-subtle">)</span>
</span>
<span v-else class="text-fg-subtle">(-)</span>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant