-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(webpack,rspack): add typeCheckOptions, runtimeDependencies, and cache options #33931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidantoon
wants to merge
18
commits into
nrwl:master
Choose a base branch
from
kiwiapps-ltd:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+337
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added documentation for the mergeExternals option in NxAppWebpackPlugin.
…config.ts Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
# Conflicts: # docs/shared/packages/webpack/webpack-plugins.md # packages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.ts # packages/webpack/src/plugins/nx-webpack-plugin/nx-app-webpack-plugin-options.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
skipTypeCheckingoption is a simple boolean that only allows enabling/disabling type checkingruntimeDependenciesoption that webpack hascacheconfiguration is hardcoded and cannot be overridden by usersExpected Behavior
typeCheckOptionsoption allows configuring type checking with{ async: true }to run type checking in a separate process without blocking the buildskipTypeCheckingoption is maintained for backward compatibilityruntimeDependenciesoption for adding runtime dependencies to generatedpackage.json(useful for Docker installs)cacheoption allows users to override webpack/rspack caching behavior while maintaining backward-compatible defaultsRelated Issue(s)
N/A - Standalone feature
Changes Made
typeCheckOptions (webpack & rspack)
TypeCheckOptionsinterface withasyncpropertytypeCheckOptionsoption to plugin options interfacesapply-base-config.tsto normalizetypeCheckOptionsfrom deprecatedskipTypeCheckingfor backward compatibilityschema.jsonandschema.d.tsruntimeDependencies (webpack & rspack)
runtimeDependenciesoption toNxAppRspackPluginOptionsGeneratePackageJsonPluginto resolve and include runtime dependenciesschema.jsonandschema.d.tscache (webpack & rspack)
cacheoption to plugin options interfacesapply-base-config.tsto check'cache' in optionsbefore applying defaultscache: undefinedto force cache to be disabled{ type: 'memory' }for Node targets in watch modetruefor Node targets in watch mode,truein dependent configFiles Changed
Webpack:
packages/webpack/src/plugins/nx-webpack-plugin/nx-app-webpack-plugin-options.tspackages/webpack/src/plugins/nx-webpack-plugin/lib/apply-base-config.tspackages/webpack/src/executors/webpack/schema.jsonpackages/webpack/src/executors/webpack/schema.d.tspackages/webpack/src/plugins/generate-package-json-plugin.tsRspack:
packages/rspack/src/plugins/utils/models.tspackages/rspack/src/plugins/utils/apply-base-config.tspackages/rspack/src/plugins/utils/plugins/generate-package-json-plugin.tspackages/rspack/src/executors/rspack/schema.jsonpackages/rspack/src/executors/rspack/schema.d.tsDocumentation:
astro-docs/.../webpack/Guides/webpack-plugins.mdocpackages/webpack/docs/webpack-build-executor-examples.md