Skip to content

feat: end to end wiring for per message nack#220

Draft
vaibhavtiwari33 wants to merge 7 commits into
mainfrom
per-msg-nack
Draft

feat: end to end wiring for per message nack#220
vaibhavtiwari33 wants to merge 7 commits into
mainfrom
per-msg-nack

Conversation

@vaibhavtiwari33

Copy link
Copy Markdown
Contributor

Closes #209

Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.55556% with 13 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@0c3b01c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../java/io/numaproj/numaflow/shared/NackOptions.java 77.77% 0 Missing and 4 partials ⚠️
...main/java/io/numaproj/numaflow/sinker/Service.java 57.14% 0 Missing and 3 partials ⚠️
...java/io/numaproj/numaflow/batchmapper/Service.java 71.42% 0 Missing and 2 partials ⚠️
...aproj/numaflow/mapstreamer/OutputObserverImpl.java 75.00% 0 Missing and 2 partials ⚠️
...j/numaflow/sourcetransformer/TransformerActor.java 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage        ?   61.35%           
  Complexity      ?      592           
=======================================
  Files           ?      156           
  Lines           ?     3628           
  Branches        ?      268           
=======================================
  Hits            ?     2226           
  Misses          ?     1225           
  Partials        ?      177           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Per-Message Nack Support for Java SDK

1 participant