Skip to content

MAINT: Fix two cases of code injection via template expansion#39

Merged
andyfaff merged 2 commits intonumpy:mainfrom
agriyakhetarpal:zizmor-reports-31032026
Apr 8, 2026
Merged

MAINT: Fix two cases of code injection via template expansion#39
andyfaff merged 2 commits intonumpy:mainfrom
agriyakhetarpal:zizmor-reports-31032026

Conversation

@agriyakhetarpal
Copy link
Copy Markdown
Contributor

This PR fixes two cases of template injection that Zizmor caught, from a local run.

cc: @rgommers

@rgommers
Copy link
Copy Markdown
Member

Thanks @agriyakhetarpal. I'm not sure this is a valid concern for this repo, given that we don't run CI on PRs from anyone but release team and org admin members. So the reason to change this would be to make using zizmor easier.

@agriyakhetarpal
Copy link
Copy Markdown
Contributor Author

agriyakhetarpal commented Mar 31, 2026

Thanks @rgommers. Indeed, this only changes what I saw through zizmor. Running the tool locally occasionally might be a good idea, as I mentioned to you privately elsewhere, in the extremely unlikely event that this repository gets compromised (this is still an attack vector, though a tad difficult to exploit here). If you and the rest of the release team agree with this PR at some later point, please feel free to merge this from the command line as you like, or merge it manually.

@andyfaff andyfaff force-pushed the zizmor-reports-31032026 branch from 6874f7c to d651502 Compare April 8, 2026 08:36
@andyfaff
Copy link
Copy Markdown
Member

andyfaff commented Apr 8, 2026

It seems like a +0.5 change, so it's worth merging if CI passes (the run was manually approved).

@andyfaff andyfaff merged commit fd25354 into numpy:main Apr 8, 2026
58 checks passed
@agriyakhetarpal agriyakhetarpal deleted the zizmor-reports-31032026 branch April 8, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants