Update Cookbook direnv instructions for new std helper#1878
Conversation
NotTheDr01ds
added
the
wait-after-next-release
|
Nice! What is to be done with this tip on the page?
nu-scripts uses a different implementation. In fact, 2 days ago a separate fix was introduced for the nu-scripts implementation. Currently it would be confusing for users whether to use the solution in the cookbook or the one in nu_scripts. Maybe it would be smart to keep only a single implementation around, considering that this is not the first time that the implementation in the cookbook and nu-scripts have diverged? |
That's my thought as well. Seems to be a better fit for the Cookbook, both in terms of discoverability and the fact that the |
|
Put in nushell/nu_scripts#1084 to remove the nu_scripts version. Also updated verbage. |
When combined with [the Cookbook update](nushell/nushell.github.io#1878), this resolves #15452 # Description When we removed the startup `ENV_CONVERSION` for path, as noted in the issue above, we removed the ability for users to access this closure for other purposes. This PR adds the PATH closures back as a `std` commands that outputs a record of closures (similar to `ENV_CONVERSIONS`). # User-Facing Changes Doc will be updated and users can once again easily access `direnv` # Tests + Formatting - 🟢 `toolkit fmt` - 🟢 `toolkit clippy` - 🟢 `toolkit test` - 🟢 `toolkit test stdlib` # After Submitting Doc PR to be merged when released in 0.104
|
Can this also be merged now, since nushell/nu_scripts#1084 has been merged? |
|
It would be great if this could be merged. The tip that this removes contains a link to a file that was removed by the aforementioned PR and I was about to open a fix when I noticed that this change was pending. cc the most recent commiters @cptpiepmatz @fdncred |
|
Thanks |
4 participants
As mentioned in nushell/nushell#15569 - This updates the
direnvformula in the Cookbook to utilize the newstd/config env-conversionshelper.