Update external_completers.md - Fix fish quotes for ISS1881#1883
Merged
Conversation
Invert fish quotes to prevent issues where the output is a single double quote, breaking the string substitution nushell#1881
Contributor
Author
|
somehow amidst all the data processing and pipelining, simple string quotes are becoming the least intuitive thing to me in nushell lol. |
Contributor
|
Thanks |
Member
|
Thanks for the quick fix! |
1 similar comment
Member
|
Thanks for the quick fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invert fish quotes to prevent issues where the output is a single double quote, breaking the string substitution
#1881
the TL;DR above is that if you do something like
cat <TAB>instead ofcat scri<TAB>the string substitution would break from some funky nushell quoting issues.cc @ysthakur