chore(website): migrate webpack configs to ESM#4351
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4351 +/- ##
==========================================
+ Coverage 54.52% 56.30% +1.77%
==========================================
Files 274 308 +34
Lines 6076 6962 +886
Branches 1455 1682 +227
==========================================
+ Hits 3313 3920 +607
- Misses 2763 3042 +279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Confidence Score: 4/5
|
Member
Member
Author
|
Yes, thanks for the reminder. I'll also be investigating. |
Member
|
Opened a PR here: #4357 |
Member
Author
|
Let's not bother with this since the noisy warnings no longer show up during development and build (cuz the Babel plugin has been removed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
The website webpack config stack was still using CommonJS while the rest of the website codebase had already largely moved to
lodash-es.This updates the webpack-related config files to ESM and removes the remaining direct
lodashusage from thewebsitepackage.Implementation
.jsto.mjswebsitescripts and ESLint config to consume the ESM webpack config files correctlyeslint-import-resolver-webpackwebsitelodashusage tolodash-eslodashand@types/lodashfromwebsite/package.jsonpnpm-lock.yamlValidation:
pnpm exec eslint --ext .js,.mjs .eslintrc.js scripts/build.js scripts/apply-venue-updates.js scripts/fix-venue-name.js scripts/sitemap.js webpackNODE_ENV=development pnpm exec webpack configtest webpack/webpack.config.dev.mjsNODE_ENV=production pnpm exec webpack configtest webpack/webpack.config.browser-warning.mjsNODE_ENV=development pnpm exec webpack configtest webpack/webpack.config.timetable-only.mjsOther Information
I did not run a full
pnpm --dir website buildin this branch.