Skip to content

perf(nuxi): use loadNuxtConfig instead of loadNuxt in preview command #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zlotnika wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −26
Open

perf(nuxi): use loadNuxtConfig instead of loadNuxt in preview command #1275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73b1611
perf(nuxi): use `loadNuxtConfig` instead of `loadNuxt` in preview com…
zlotnika Apr 3, 2026
ab194f7
fix: use rootDir instead of srcDir for output path resolution
zlotnika Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 16 additions & 26 deletions packages/nuxi/src/commands/preview.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,37 +37,27 @@ const command = defineCommand({

const cwd = resolve(ctx.args.cwd || ctx.args.rootDir)

const { loadNuxt } = await loadKit(cwd)

const resolvedOutputDir = await new Promise<string>((res) => {
loadNuxt({
// Resolve the output directory from config without running module setup
// (which may emit warnings about env vars already baked into the build).
const { loadNuxtConfig } = await loadKit(cwd)
const config = await loadNuxtConfig({
cwd,
dotenv: {
cwd,
dotenv: {
cwd,
fileName: ctx.args.dotenv,
},
envName: ctx.args.envName, // c12 will fall back to NODE_ENV
ready: true,
overrides: {
...(ctx.args.extends && { extends: ctx.args.extends }),
modules: [
function (_, nuxt) {
nuxt.hook('nitro:init', (nitro) => {
res(resolve(nuxt.options.srcDir || cwd, nitro.options.output.dir || '.output', 'nitro.json'))
})
},
],
},
}).then(nuxt => nuxt.close()).catch(() => '')
fileName: ctx.args.dotenv,
},
envName: ctx.args.envName,
overrides: {
...(ctx.args.extends && { extends: ctx.args.extends }),
},
})

const defaultOutput = resolve(cwd, '.output', 'nitro.json') // for backwards compatibility
const outputDir = config.nitro?.output?.dir ?? '.output'
const nitroJSONPath = resolve(config.rootDir || cwd, outputDir, 'nitro.json')

const nitroJSONPaths = [resolvedOutputDir, defaultOutput].filter(Boolean)
const nitroJSONPath = nitroJSONPaths.find(p => existsSync(p))
if (!nitroJSONPath) {
if (!existsSync(nitroJSONPath)) {
logger.error(
`Cannot find ${colors.cyan('nitro.json')}. Did you run ${colors.cyan('nuxi build')} first? Search path:\n${nitroJSONPaths.join('\n')}`,
`Cannot find ${colors.cyan('nitro.json')}. Did you run ${colors.cyan('nuxi build')} first? Search path:\n${nitroJSONPath}`,
)
process.exit(1)
}
Expand Down
Loading