Conversation
See https://npmx.dev/package/@netlify/nuxt. The current module under the `netlify` name is a very outdated, unmaintained module that only supports Nuxt 2. See https://npmx.dev/package/@aceforth/nuxt-netlify.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated two module manifest files. modules/netlify.yml replaces Nuxt-Netlify–specific metadata with Netlify primitives and related URLs: description, repo, npm package, icon, github, website, learn_more, maintainers, and Nuxt compatibility updated from ^2.0.0 to ^3.0.0 || ^4.0.0. modules/netlify-files.yml updates only the icon value from Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@modules/netlify.yml`:
- Around line 4-5: The repo field is pointing at the monorepo root (repo:
netlify/primitives) which causes sync() to read the wrong package.json; update
the repo value to reference the Nuxt package subdirectory (use repo:
netlify/primitives#main/packages/nuxt-module) so the correct package.json for
the `@netlify/nuxt` npm package is fetched and the npm field is not overwritten.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d6c77a62-f346-42f9-8b36-753bdef2b951
⛔ Files ignored due to path filters (2)
icons/netlify.pngis excluded by!**/*.pngicons/netlify.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
modules/netlify.yml
|
Do you think while I'm here we can remove https://github.com/nuxt/modules/blob/e604f1e7ea5f13454df886fe82666d0d28e239d2/modules/netlify-files.yml? It also seems to be quite outdated (Nuxt 2 only) and of limited value. |
Co-authored-by: Philippe Serhal <philippe.serhal@gmail.com>
🔗 Linked issue
😶
📚 Description
This PR adds
@netlify/nuxtto the module registry. See https://npmx.dev/package/@netlify/nuxt.The current module under the
netlifyname is a very outdated, unmaintained module that only supports Nuxt 2. See https://npmx.dev/package/@aceforth/nuxt-netlify. It seems reasonable to me to take the name over with the official, maintained@netlify/nuxt.