Skip to content

fix(module): validate required registry fields after runtime merge #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsukiyama-3 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(module): validate required registry fields after runtime merge #762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion packages/script/src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,20 @@ export default defineNuxtModule<ModuleOptions>({
const willAutoLoad = scriptOptions && 'trigger' in scriptOptions && scriptOptions.trigger !== false
if (willAutoLoad) {
const requiredFields = extractRequiredFields(script.schema)
const missing = requiredFields.filter(f => !input[f])

const publicScripts = (nuxt.options.runtimeConfig.public?.scripts ?? {}) as Record<string, Record<string, unknown>>
const publicScriptEntry = publicScripts[key]
const effectiveInput: Record<string, unknown>
= publicScriptEntry
&& typeof publicScriptEntry === 'object'
&& !Array.isArray(publicScriptEntry)
? Object.fromEntries(
Object.entries(publicScriptEntry).filter(([prop]) => prop !== 'scriptOptions'),
)
: input

const missing = requiredFields.filter(f => !effectiveInput[f])

if (missing.length) {
logger.warn(`[nuxt-scripts] registry.${key}: missing required field${missing.length > 1 ? 's' : ''} ${missing.map(f => `'${f}'`).join(', ')}. The script infrastructure is registered but will not function without ${missing.length > 1 ? 'them' : 'it'}.`)
}
Expand Down
Loading