feat(Modal): support unmountOnHide prop#6523
Draft
benjamincanac wants to merge 1 commit into
Draft
Conversation
Forward the `unmountOnHide` prop (inherited from `DialogRootProps`) to the underlying `DialogRoot` in Modal and Slideover, and proxy it through ContentSearch and DashboardSearch. When set to `false`, the content stays in the DOM while closed (hidden via `display: none`) instead of being unmounted, avoiding remounts on every open. Defaults to `true` to keep the existing behavior.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Depends on unovue/reka-ui#2662 (adds
unmountOnHidetoDialogRoot).❓ Type of change
📚 Description
Adds support for the
unmountOnHideprop (inherited fromDialogRootProps) onModalandSlideover, and proxies it throughContentSearchandDashboardSearch.When set to
false, the content stays in the DOM while closed (hidden viadisplay: none) instead of being unmounted, which avoids remounting (and recomputing) the content on every open. Useful for heavy content like aCommandPaletteinside a search modal. Defaults totrue, so existing behavior is unchanged.Modal/Slideover: forwardunmountOnHidetoDialogRootand add it towithDefaultsso the default shows in the docs API tableContentSearch/DashboardSearch: expose and forward the prop to their innerModal:unmount-on-hide="false"docs: opt into:unmount-on-hide="false"on the search modal so the command palette isn't rebuilt on every openNote
This relies on the reka-ui changes from unovue/reka-ui#2662 (plus follow-up
DismissableLayer/FocusScopefixes for the force-mount case). Thepackage.jsonpin currently points at the pkg.pr.new build — it should be bumped to a real release before merge.📝 Checklist