fix(Textarea): prevent baseline shift in forms#6559
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR addresses a form layout shift that occurs when a textarea is empty and disabled during form submission. The change adds Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
What changed
Adds �lign-top to the Textarea root classes so it doesn't participate in baseline alignment when it sits inline in a form layout.
This keeps the existing Input root classes intact, but avoids the small vertical jump that can show up when an empty textarea is disabled during submit.
Fixes #6541
Testing
npm run test -- Textareanpm exec -- eslint src/theme/textarea.ts test/components/Textarea.spec.tsnpm run build