Open
Conversation
The obx_data_visitor in core is: ```c typedef bool obx_data_visitor(const void* data, size_t size, void* user_data); ``` So the `dataVisitorDispatch` function in Go have wrong parameter order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
obx_data_visitorin ObjectBox Core (C library) is:The first two parameter should be data and size according to the C header file, the third parameter is the user data.
But objectbox-go defined
dataVisitorDispatchfunction in Go has a wrong parameter order:visitorIdPtrwas passed as user data here:This might lead to a crash when you use a ObjectBox Core C version without
OBXFeature_ResultArray(e.g. Mobile version like iOS).Simply re-order the parameter will fix this issue: