feat(#65): get lints for gh-pages in runtime by Marat-Tim · Pull Request #137 · objectionary/lints

Marat-Tim · 2024-12-11T18:15:58Z

adds all motives of active lints to the Github pages branch

Marat-Tim · 2024-12-11T18:16:10Z

I understand that there are many errors here, but I wanted to do something so that you could specifically point them out to me

yegor256 · 2024-12-11T22:13:37Z

@Marat-Tim looks like a good start! Now, please, try to make all build jobs pass.

Marat-Tim · 2025-01-29T15:38:08Z

@yegor256 I'm ready for my code to be destroyed)

I have a few questions

Do we collect the jar file somewhere and can we download it from there? Then from pom.xml it will be possible to remove the build plugin in jar
I assume that the PrintAllLines class needs to be moved to a separate project. If I create a project in the repository, won't it break some kind of pipeline? And again, how can I connect the latest version of the main project to subproject?
On behalf of whom to make a push request to the gh-pages branch? Now I've done it on my own login
How good is the idea of JavaLint? After all, if I wrap it at the wrong moment (for example, after wrapping it in Unlint), the name will be lost. Or you'll have to recursively get the decorated object, which sounds pretty crooked

github-actions · 2025-04-23T22:14:16Z

🚀 Performance Analysis

All benchmarks are within the acceptable range. No critical degradation detected (threshold is 100%). Please refer to the detailed report for more information.

Click to see the detailed report

Test	Base Score	PR Score	Change	% Change	Unit	Mode
`benchmarks.SourceBench.scansXmir (size=S)`	5875.736	6033.971	158.235	2.69%	ms/op	Average Time
`benchmarks.SourceBench.scansXmir (size=M)`	6330.787	6485.224	154.437	2.44%	ms/op	Average Time
`benchmarks.SourceBench.scansXmir (size=L)`	7308.019	7469.824	161.806	2.21%	ms/op	Average Time
`benchmarks.SourceBench.scansXmir (size=XL)`	8632.580	8694.309	61.729	0.72%	ms/op	Average Time
`benchmarks.SourceBench.scansXmir (size=XXL)`	20930.917	21153.280	222.363	1.06%	ms/op	Average Time

⚠️ Performance loss: benchmarks.SourceBench.scansXmir (size=S) is slower by 158.235 ms/op (2.69%)
⚠️ Performance loss: benchmarks.SourceBench.scansXmir (size=M) is slower by 154.437 ms/op (2.44%)
⚠️ Performance loss: benchmarks.SourceBench.scansXmir (size=L) is slower by 161.806 ms/op (2.21%)
⚠️ Performance loss: benchmarks.SourceBench.scansXmir (size=XL) is slower by 61.729 ms/op (0.72%)
⚠️ Performance loss: benchmarks.SourceBench.scansXmir (size=XXL) is slower by 222.363 ms/op (1.06%)

Marat-Tim · 2025-04-23T22:37:25Z

@yegor256 I updated and corrected the pull request. An example of how the gh-pages branch will be created with it can be viewed here

yegor256 · 2025-04-24T05:41:40Z

@Marat-Tim the SaveAll.java file is not in the right place. It's among feature files, which are shipped to the client in the final JAR. Should it be there? Maybe we can replace it with a Bash script?

yegor256 · 2025-04-24T05:41:48Z

@h1alexbel please, take a look

Marat-Tim · 2025-04-24T08:23:41Z

@yegor256 We can't replace java code with bash if we want to get a list of motives in java runtime. I also tried to move this executable file to a separate subproject (similar to lints-it), but I ran into the problem that PkWpa and PkMono are not public classes, so the only way to use them is to write a file in the main project

Would it be better to just exclude this file from the build into the final jar? I just don't really understand which plugin this assembly is configured in, if you tell me, it will be very good for me.

pom.xml

src/main/java/org/eolang/lints/SaveAll.java

h1alexbel

@Marat-Tim check my comments, please

.github/motives.groovy

h1alexbel · 2025-04-25T13:11:06Z

pom.xml

+        <version>4.1.1</version>
+        <configuration>
+          <scripts>
+            <script>./.github/motives.groovy</script>


@Marat-Tim let's move the script into src/main/groovy/org/eolang/lints/motives.groovy

@h1alexbel when I tried to do this, I got an error jcabi/jcabi-parent#586

I added a puzzle to this fix

@h1alexbel I'm not sure how to check this - could the presence of a groovy folder cause the entire Groovy runtime to be bundled into the final JAR?

@Marat-Tim in the jcabi-parent, we have this groovy profile:

<profile>  <id>groovy</id> <activation> <file> <exists>${basedir}/src/main/groovy</exists> </file> </activation> <dependencies> <dependency> <groupId>org.codehaus.groovy</groupId> <artifactId>groovy-all</artifactId> <version>3.0.24</version> <type>pom</type> </dependency> </dependencies> <build> <plugins> <plugin> <groupId>org.codehaus.gmavenplus</groupId> <artifactId>gmavenplus-plugin</artifactId> <version>4.2.0</version> <configuration> <verbose>true</verbose> </configuration> <executions> <execution> <id>jcabi-groovy</id> <goals> <goal>compile</goal> <goal>compileTests</goal> </goals> </execution> </executions> </plugin> </plugins> </build> </profile>

@h1alexbel Honestly, I don't quite get it
When I run mvn install without any profiles, I see that classes from the groovy folder end up in target/classes
I'm concerned that this might cause the Groovy runtime to be bundled into the final JAR
Are my concerns unfounded?

@Marat-Tim correct. Your Groovy scripts should be located in the target/classes. From there you can invoke them using gmavenplus-plugin passing path to the script:

<scripts> <script>src/main/groovy/org/eolang/lints/SaveMotives.groovy</script> </scripts>

.github/motives.groovy

h1alexbel · 2025-04-25T13:15:43Z

.github/motives.groovy

+
+package org.eolang.lints
+
+static def saveLint(Lint<?> lint) {


@Marat-Tim maybe we can setup tests for saveLint() method, in the src/test/groovy? Otherwise, we don't and won't know if we break something during the future modifications. WDYT?

@h1alexbel when I tried to do this, I got an error jcabi/jcabi-parent#586

I added a puzzle to this fix

@Marat-Tim maybe you can remove the puzzle, since we released a new version of jcabi-parent?

Marat-Tim · 2025-04-27T11:09:29Z

@h1alexbel

maxonfjvipon · 2025-04-27T11:10:47Z

@h1alexbel please check this one

h1alexbel

@Marat-Tim just one comment, please check

h1alexbel · 2025-04-27T11:20:31Z

.github/motives.groovy

+ * This script saves a file with the lint name and extension .md to the tmp folder.
+ * The motive of this lint is preserved as content.
+ * These files are saved for all active lints in the project.
+ * @todo #65:30min after fixing this problem with creation of groovy folder


@Marat-Tim let's make two todos for these issues:

"Move this script to the src/main/groovy folder."

"Write a test for motives.groovy"

h1alexbel

@Marat-Tim LGTM

h1alexbel · 2025-04-28T08:50:17Z

@yegor256 take a look, please

Marat-Tim · 2025-05-06T08:39:30Z

@yegor256

yegor256

a new version of jcabi-parent is available

yegor256 · 2025-05-12T18:11:19Z

.github/motives.groovy

+
+package org.eolang.lints
+
+static def saveLint(Lint<?> lint) {


@Marat-Tim maybe you can remove the puzzle, since we released a new version of jcabi-parent?

Marat-Tim · 2025-05-13T09:52:18Z

@yegor256 Yes, I'm working on it right now - but I've got a question: #137 (comment)

Marat-Tim force-pushed the 65 branch 4 times, most recently from 65fd9ec to db25c7c Compare December 11, 2024 18:35

Marat-Tim force-pushed the 65 branch 4 times, most recently from 63cb8b0 to 525dc81 Compare January 29, 2025 15:18

Marat-Tim changed the title ~~feat(#65): mvp~~ feat(#65): get lints for gh-pages in runtime Feb 4, 2025

Marat-Tim force-pushed the 65 branch from 525dc81 to ce54568 Compare April 23, 2025 21:55

yegor256 requested review from h1alexbel and yegor256 and removed request for yegor256 April 24, 2025 05:41

h1alexbel suggested changes Apr 24, 2025

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

src/main/java/org/eolang/lints/SaveAll.java Outdated Show resolved Hide resolved

Marat-Tim requested a review from h1alexbel April 25, 2025 12:59

h1alexbel suggested changes Apr 25, 2025

View reviewed changes

Marat-Tim force-pushed the 65 branch from 70472d3 to ca48ba4 Compare April 25, 2025 19:51

Marat-Tim requested a review from h1alexbel April 26, 2025 08:33

Marat-Tim force-pushed the 65 branch from c6fd4fe to 1d32345 Compare April 27, 2025 10:35

h1alexbel suggested changes Apr 27, 2025

View reviewed changes

Marat-Tim requested a review from h1alexbel April 27, 2025 16:40

h1alexbel approved these changes Apr 28, 2025

View reviewed changes

h1alexbel requested a review from yegor256 April 28, 2025 08:50

Marat-Tim force-pushed the 65 branch from 8264340 to cf9fce3 Compare April 28, 2025 17:37

Marat-Tim force-pushed the 65 branch from cf9fce3 to 86617cf Compare May 5, 2025 19:36

feat(objectionary#65): add docs to README + get motives at runtime

c3192c4

Marat-Tim force-pushed the 65 branch from 86617cf to c3192c4 Compare May 12, 2025 17:33

github-actions bot added the core Changes are made to core parts of the code base label May 12, 2025

yegor256 requested changes May 13, 2025

View reviewed changes

Conversation

Marat-Tim commented Dec 11, 2024

Uh oh!

Marat-Tim commented Dec 11, 2024

Uh oh!

yegor256 commented Dec 11, 2024

Uh oh!

Marat-Tim commented Jan 29, 2025

Uh oh!

github-actions bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Performance Analysis

Uh oh!

Marat-Tim commented Apr 23, 2025

Uh oh!

yegor256 commented Apr 24, 2025

Uh oh!

yegor256 commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Marat-Tim commented Apr 24, 2025

Uh oh!

Uh oh!

Uh oh!

h1alexbel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

h1alexbel May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marat-Tim commented Apr 27, 2025

Uh oh!

maxonfjvipon commented Apr 27, 2025

Uh oh!

h1alexbel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

h1alexbel left a comment

Choose a reason for hiding this comment

Uh oh!

h1alexbel commented Apr 28, 2025

Uh oh!

Marat-Tim commented May 6, 2025

Uh oh!

yegor256 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Marat-Tim commented May 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Apr 23, 2025 •

edited

Loading

yegor256 commented Apr 24, 2025 •

edited

Loading

h1alexbel May 13, 2025 •

edited

Loading