Skip to content

Fix CI build and test errors #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuyushun441-sys merged 5 commits into from
Apr 10, 2026
+17 −18
Merged

Fix CI build and test errors #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
513c36d
Fix TypeScript error: add optional chaining for object.relationships
Claude Apr 9, 2026
404d305
Trigger CI for TypeScript fix verification
Claude Apr 9, 2026
7b53dfd
Fix test failures by registering mock components at module level
Claude Apr 9, 2026
5f2f865
Remove unused imports in UnifiedSidebar.tsx
Claude Apr 9, 2026
7a384be
Merge branch 'main' into claude/fix-ci-build-and-test-errors
xuyushun441-sys Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions apps/console/src/__tests__/MetadataDetailPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,23 +70,22 @@ vi.mock('react-router-dom', async () => {
});

// Register mock widget components for PageSchema rendering in tests
beforeEach(() => {
const mockWidget = (name: string) => (props: any) => (
<div data-testid={`mock-${name}`} data-object-name={props?.schema?.objectName || props?.objectName}>
{name}
</div>
);

ComponentRegistry.register('object-detail-tabs', mockWidget('object-detail-tabs'));
ComponentRegistry.register('object-properties', mockWidget('object-properties'));
ComponentRegistry.register('object-relationships', mockWidget('object-relationships'));
ComponentRegistry.register('object-keys', mockWidget('object-keys'));
ComponentRegistry.register('object-data-experience', mockWidget('object-data-experience'));
ComponentRegistry.register('object-data-preview', mockWidget('object-data-preview'));
ComponentRegistry.register('object-field-designer', mockWidget('object-field-designer'));
});

// Import after mocks
// IMPORTANT: Register at module level (before import) to ensure components are available
const mockWidget = (name: string) => (props: any) => (
<div data-testid={`mock-${name}`} data-object-name={props?.schema?.objectName || props?.objectName}>
{name}
</div>
);

ComponentRegistry.register('object-detail-tabs', mockWidget('object-detail-tabs'));
ComponentRegistry.register('object-properties', mockWidget('object-properties'));
ComponentRegistry.register('object-relationships', mockWidget('object-relationships'));
ComponentRegistry.register('object-keys', mockWidget('object-keys'));
ComponentRegistry.register('object-data-experience', mockWidget('object-data-experience'));
ComponentRegistry.register('object-data-preview', mockWidget('object-data-preview'));
ComponentRegistry.register('object-field-designer', mockWidget('object-field-designer'));

// Import after registering mock components
import { MetadataDetailPage } from '../pages/system/MetadataDetailPage';

function renderWithRoute(metadataType: string, itemName: string) {
Expand Down
2 changes: 1 addition & 1 deletion apps/console/src/components/schema/objectDetailWidgets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export function ObjectRelationshipsWidget({ schema }: { schema: ObjectWidgetSche
</h3>
{hasRelationships ? (
<div className="space-y-3">
{(object.relationships ?? []).map((rel, i) => (
{object.relationships?.map((rel, i) => (
<div
key={i}
className="flex items-start gap-4 p-4 rounded-lg border bg-card hover:bg-accent/50 transition-colors"
Expand Down
Loading