Conversation
mbostock
left a comment
There was a problem hiding this comment.
What about the alternative fix of putting the marker into a defs element (or simply outside the g element, somewheres) so that it doesn’t inherit attributes? Would that be a more general fix? For example, is there a similar issue with the fill and stroke-opacity being inherited (or is that inheritance desirable)?
(Was wondering if there would be an issue here if strokeDasharray were specified as a channel, but that’s not supported, so it’s nice that we can simplify. Was also wondering if we should always set stroke-dasharray="none" but I guess it’s nice to avoid if necessary.)
|
a) I believe b) I researched the idea of using an external |
mbostock
left a comment
There was a problem hiding this comment.
I simplified this to just always set stroke-dasharray=none, which I feel is more consistent with how we handle the other attributes. That causes some redundant effort (especially since stroke-dasharray is rare), but it seems fine.

closes #2131