throw Error: invalid dodge radius for negative constant radius#2385
Open
throw Error: invalid dodge radius for negative constant radius#2385
Conversation
…k overflow. closes #1912
mbostock
reviewed
Apr 1, 2026
Member
mbostock
left a comment
mbostock
left a comment
There was a problem hiding this comment.
Are there other invalid radii that we need to test for? I guess testing for an invalid constant radius is cheap, but what happens if you define it as a function, and that function returns entirely bad values? Should there be some more general check that gives a better error, or well-defined behavior? For example, should we treat any invalid radius as zero?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(instead of crashing with a stack overflow)
closes #1912