Unset the jobs variable from the opam config (faulty opam 2.0 behaviour)#92
Draft
kit-ty-kate wants to merge 1 commit intoocurrent:masterfrom
Draft
Unset the jobs variable from the opam config (faulty opam 2.0 behaviour)#92kit-ty-kate wants to merge 1 commit intoocurrent:masterfrom
kit-ty-kate wants to merge 1 commit intoocurrent:masterfrom
Conversation
tmcgilchrist
approved these changes
Sep 8, 2022
Collaborator
|
The problem doing this in the base is that it breaks 2.0 - opam 2.1 recomputes the |
Contributor
|
@kit-ty-kate can this be merged now that the opam PR is merged? |
Contributor
Author
|
@benmandrew the opam PR only fixes things when upgrading to opam 2.2. David’s comment above is still very much the main blocker, so until the images are upgraded to a more recent opam by default this PR can’t be merged. |
Member
|
iiuc, addressing ocurrent/docker-base-images#132 would unblock this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opam 2.0 by default stores the number of cores of the current machine. While not too much of a big deal for users, this is extremely bad for the base images where the number stored will be around 72 but these can be used on any other machines.
This might help fighting the IO overload on the cluster.