Skip to content

Server framework 101#1339

Open
LucasDaniOV wants to merge 1 commit into
odoo:19.0from
odoo-dev:19.0-onboarding-luoud
Open

Server framework 101#1339
LucasDaniOV wants to merge 1 commit into
odoo:19.0from
odoo-dev:19.0-onboarding-luoud

Conversation

@LucasDaniOV

Copy link
Copy Markdown

No description provided.

@LucasDaniOV LucasDaniOV requested a review from ziriraha June 15, 2026 09:45
@robodoo

robodoo commented Jun 15, 2026

Copy link
Copy Markdown

Pull request status dashboard

@ziriraha ziriraha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, one thing to keep in mind is that you should add a new link at the end of each file. i recommend setting up your editor to add it for you.

Comment thread estate/__manifest__.py Outdated
Comment thread estate/models/estate_property.py
@LucasDaniOV LucasDaniOV changed the title Server framework 101 - chapter 2 Server framework 101 Jun 16, 2026
@LucasDaniOV LucasDaniOV force-pushed the 19.0-onboarding-luoud branch from 7b557ac to c06fdb3 Compare June 16, 2026 11:01

@ziriraha ziriraha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Comment thread estate/models/estate_property.py Outdated
@LucasDaniOV

Copy link
Copy Markdown
Author

nice work

thank you

@ziriraha ziriraha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, a couple small comments

msg_0 = "Property is already sold"
raise exceptions.UserError(msg_0)
property.state = "sold"
return True

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi (i dont know if its explained in the tutorial) actions can return action objects so you can say things like: open this popup, reload the page, redirect to here

Comment thread estate_account/security/ir.model.access.csv Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property_offer.py Outdated
Comment thread estate/views/estate_property_tag_views.xml Outdated
Comment thread estate_account/__manifest__.py Outdated
Comment thread estate_account/__manifest__.py Outdated
Comment thread estate/__manifest__.py Outdated
@LucasDaniOV LucasDaniOV requested a review from ziriraha June 22, 2026 07:58

@ziriraha ziriraha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know if i said this before, but can we squash all commits into a single one please?

Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property.py
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/estate_property_offer.py Outdated
Comment thread estate_account/models/estate_property.py Outdated
Comment thread estate_account/models/estate_property.py Outdated
@LucasDaniOV LucasDaniOV force-pushed the 19.0-onboarding-luoud branch from c402373 to ed3cc33 Compare June 22, 2026 15:53
@LucasDaniOV LucasDaniOV requested a review from ziriraha June 22, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants