Skip to content

Conversation

@oising
Copy link
Owner

@oising oising commented Aug 28, 2025

  • move to 9.4.1
  • move to eventing (remove hooks)
  • clean up

Copilot AI review requested due to automatic review settings August 28, 2025 03:08
@oising oising self-assigned this Aug 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Aspire Project Commander to move from lifecycle hooks to an eventing-based approach and includes various clean-up improvements. The changes modernize the codebase by replacing the hook-based lifecycle management with a more streamlined eventing system and improve code organization.

Key changes:

  • Replaced lifecycle hooks with eventing for resource initialization
  • Simplified ProjectCommanderHubResource constructor and parameter passing
  • Updated project command structure to use a new ProjectCommand record type

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ServiceCollectionAspireProjectCommanderExtensions.cs Added unknown parameter to client registration method
ResourceBuilderProjectCommanderExtensions.cs Introduced ProjectCommand record and updated method signature
ProjectCommanderHubResource.cs Simplified constructor and moved dependencies to method parameters
ProjectCommanderHubLifecycleHook.cs Removed entire lifecycle hook implementation
ProjectCommanderHub.cs Updated parameter names and improved logging
Nivot.Aspire.Hosting.ProjectCommander.csproj Added JetBrains.Annotations package reference
DistributedApplicationBuilderExtensions.cs Replaced lifecycle hooks with eventing approach
Program.cs Updated project command usage to use new ProjectCommand syntax
Consumer/Program.cs Added project commander client registration
Consumer/Consumer.csproj Added project reference dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

oising and others added 2 commits August 27, 2025 23:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@oising oising merged commit af7c66f into main Aug 28, 2025
4 checks passed
@oising oising deleted the test-interaction branch August 28, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants