Allow passing timestamp to constructor of uuid7#174
Open
daniel347x wants to merge 2 commits intooittaa:mainfrom
Open
Allow passing timestamp to constructor of uuid7#174daniel347x wants to merge 2 commits intooittaa:mainfrom
daniel347x wants to merge 2 commits intooittaa:mainfrom
Conversation
|
Yes please! this would be very helpful. EDIT: I posted some thoughts on how I could improve your concerns @oittaa in the related discussion page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this PR, the only way to instantiate a UUID7 is with the current moment in time. This PR allows passing a timestamp in ms instead.