Skip to content

Deduplicate incoming to_string generation in mako #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwmcguir merged 1 commit into from
Jun 23, 2026
+11 −0
Merged

Deduplicate incoming to_string generation in mako #490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions scripts/templates/validation/to_string.h.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,22 @@ inline std::string to_string(${th.make_type_name(n, tags, obj)} handle) {

%endfor
// Callback to_string functions (function pointers)
// Multiple callback typedefs can resolve to the same underlying function-pointer
// type (e.g. void(*)(void*)). Since typedefs are aliases rather than distinct
// types in C++, emit only one to_string overload per unique signature
// (returntype + parameter types) to avoid redefinition errors.
<% seen_cb_sigs = set() %>\
%for obj in th.extract_objs(specs, r"callback"):
<%
cb_sig = (obj.get('returntype'), tuple(p['type'] for p in obj.get('params', [])))
%>\
%if cb_sig not in seen_cb_sigs:
<% seen_cb_sigs.add(cb_sig) %>\
inline std::string to_string(${th.make_type_name(n, tags, obj)} ptr) {
return to_string(reinterpret_cast<const void*>(ptr));
}

%endif
%endfor
%endif
%if n == 'ze':
Expand Down
Loading