-
Notifications
You must be signed in to change notification settings - Fork 339
EC-RAG 26.01 release with code enhancement and bug fix #2409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Yongbozzz <yongbo.zhu@intel.com>
Dependency ReviewThe following issues were found:
VulnerabilitiesEdgeCraftRAG/edgecraftrag/requirements.txtScanned Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces enhancements to the EC-RAG system, focusing on supporting multiple generators per pipeline, improving agent creation logic, and implementing various UI and performance improvements. The changes enable pipelines to have both ChatQnA and FreeChat generators, enhance benchmark performance tracking, and add retry/replace functionality for failed file uploads in the knowledge base.
Changes:
- Enhanced pipeline architecture to support multiple generators (ChatQnA and FreeChat) instead of a single generator
- Improved agent creation logic to automatically create FreeChat generators when needed
- Added retry/replace functionality for failed file uploads in the knowledge base UI
- Enhanced benchmark performance tracking with improved metrics collection and timing accuracy
Reviewed changes
Copilot reviewed 48 out of 72 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| EdgeCraftRAG/ui/vue/src/views/settings/index.vue | Added conditional rendering for Pipeline and Agent tabs to optimize component lifecycle |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/Indexer.vue | Enhanced endpoint validation logic and error handling for indexer and vLLM configurations |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/Generator.vue | Refactored generator configuration to support multiple generators with independent state management |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/CreateDialog.vue | Added validation state tracking to prevent proceeding with untested endpoints |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/Table.vue | Updated table display to show generator types and fixed pagination initialization |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/components/DetailDrawer.vue | Updated to handle multiple generators in pipeline details display |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Pipeline/columnsList.ts | Modified table columns to display generator type instead of inference type |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Agent/components/UpdateDialog.vue | Removed pipeline type filtering and debug logging |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Agent/components/Table.vue | Fixed pagination initialization and added total count display |
| EdgeCraftRAG/ui/vue/src/views/settings/components/Agent/columnsList.ts | Changed agent table to display pipeline name instead of pipeline ID |
| EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/KnowledgeDetail.vue | Added comprehensive retry/replace/ignore functionality for failed file uploads |
| EdgeCraftRAG/ui/vue/src/utils/validate.ts | Updated service address validation to support HTTPS protocol |
| EdgeCraftRAG/ui/vue/src/utils/notification.ts | Added default notification duration of 3 seconds |
| EdgeCraftRAG/ui/vue/src/i18n/zh.ts | Added Chinese translations for retry, replace, ignore actions and URL validation tip |
| EdgeCraftRAG/ui/vue/src/i18n/en.ts | Added English translations for retry, replace, ignore actions and URL validation tip |
| EdgeCraftRAG/tools/quick_start.sh | Added virtual environment setup and updated package installation commands |
| EdgeCraftRAG/edgecraftrag/requirements.txt | Updated package versions for langchain-core and llama-index-core |
| EdgeCraftRAG/edgecraftrag/controllers/pipelinemgr.py | Added pipeline caching mechanism and generator type filtering |
| EdgeCraftRAG/edgecraftrag/controllers/agentmgr.py | Enhanced agent creation to auto-create FreeChat generators |
| EdgeCraftRAG/edgecraftrag/components/pipeline.py | Refactored to support multiple generators with improved benchmark tracking |
| EdgeCraftRAG/edgecraftrag/components/generator.py | Added generator cloning functionality and enhanced streaming with benchmark support |
| EdgeCraftRAG/edgecraftrag/components/benchmark.py | Improved benchmark data management and vLLM metrics collection |
| EdgeCraftRAG/edgecraftrag/base.py | Separated BenchType enum from CompType for better categorization |
| EdgeCraftRAG/edgecraftrag/api/v1/pipeline.py | Updated pipeline API to handle multiple generators and improved benchmark response |
| EdgeCraftRAG/edgecraftrag/api/v1/chatqna.py | Updated to use generator type when accessing pipeline generators |
| EdgeCraftRAG/edgecraftrag/api/v1/agent.py | Added pipeline status management for agent bound pipelines |
Comments suppressed due to low confidence (1)
EdgeCraftRAG/ui/vue/src/components/TableColumns.vue:1
- The CSS color syntax
rgb(from var(...) r g b / 0.4)is part of CSS Color Module Level 5 which may not be widely supported. Consider using a more compatible approach like defining the opacity value separately or using rgba() with a fallback.
<template>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EdgeCraftRAG/ui/vue/src/views/chatbot/components/KnowledgeBase/KnowledgeDetail.vue
Show resolved
Hide resolved
...CraftRAG/ui/vue/src/views/settings/components/Pipeline/components/UpdateDialog/Generator.vue
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
Description
Code enhancement and known issue fix :
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a
Tests