Skip to content

fix: correct variable name#609

Closed
yoctoyotta1024 wants to merge 1 commit intoopen-atmos:mainfrom
yoctoyotta1024:patch-1
Closed

fix: correct variable name#609
yoctoyotta1024 wants to merge 1 commit intoopen-atmos:mainfrom
yoctoyotta1024:patch-1

Conversation

@yoctoyotta1024
Copy link
Copy Markdown

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.69%. Comparing base (a921acc) to head (44e51fc).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          39       39           
  Lines        1697     1697           
=======================================
  Hits         1573     1573           
  Misses        124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Copy Markdown
Member

slayoo commented Jul 22, 2025

@Sfonxu (as we talked about it today), the key issue here is that without the change the code would not work, but the change is in a conditional branch that never gets executed on CI - which is a bug by itself. In #611, we suggest to split the example into two separate ones, so that the conditional expression goes away, and both "bin" and "bulk" code branches would be executed. Hence, suggest introducing this "split" in this PR - let's look at it on Thu.

thanks @yoctoyotta1024 for reporting it!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 3, 2026

Stale pull request message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants