Conversation
- Allow individual Neuropixels 2.0 probes to be enabled, independently of whether or not they are plugged in - Enhanced updateSettings method to handle individual streams for Neuropixels2e probes based on their enabled state. - Removed NeuropixelsV2eInterface and replaced it with a probe-specific interface for better modularity. - Updated UI components to reflect changes in probe handling and added enable/disable functionality for probes. - Refactored probe index handling to use a consistent naming convention (m_probeIndex). - Improved error handling and user feedback in the probe interface.
jonnew
requested changes
Jul 10, 2025
Contributor
jonnew
left a comment
jonnew
left a comment
There was a problem hiding this comment.
Issues found during testing
- If I disable Neuropixels 2.0 probe using np2.0e headstage leaving only the Bno055 enabled, when I press play i get this message:
but only 1 time. The second time I press play acquisition starts, however no data is produced by the polled bno055. This appears to be the same issue as is documented in the third point of this issue: open-ephys/bonsai-onix1#468. However this is a bit different because it happens every other time indicating that if power is left on the state is corrected once every other time we try to write to a BNO register.
- A secondary issue that does not seem related to the first is that Breakpoint here indicates that:
bnoBuffer->addToBuffer(bnoSamples.data(), sampleNumbers, bnoTimestamps, eventCodes, NumFrames);
is getting called but for some reason data not propagating to the LFP viewer. I see no updates on the Bno stream.
- The enable/disable state for probes does not seem to be saved across GUI uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Neuropixels2e integration and update UI components
Allow individual Neuropixels 2.0 probes to be enabled, independently of whether or not they are plugged in
Enhanced updateSettings method to handle individual streams for Neuropixels2e probes based on their enabled state.
Removed NeuropixelsV2eInterface and replaced it with a probe-specific interface for better modularity.
Updated UI components to reflect changes in probe handling and added enable/disable functionality for probes.
Refactored probe index handling to use a consistent naming convention (m_probeIndex).
Improved error handling and user feedback in the probe interface.
Fixes Add ability to disable individual Neuropixels 2.0e probes #45