Removed the border-radius: 25px; line from AcknowledgmentPicker.scss#45
Closed
sabogalc wants to merge 2 commits intoopen-imcore:masterfrom
Closed
Removed the border-radius: 25px; line from AcknowledgmentPicker.scss#45sabogalc wants to merge 2 commits intoopen-imcore:masterfrom
border-radius: 25px; line from AcknowledgmentPicker.scss#45sabogalc wants to merge 2 commits intoopen-imcore:masterfrom
Conversation
… of the acknowledgment menu more dark mode friendly
…mentPicker.scss`
sabogalc
changed the title
border-radiusborder-radius: 25px; line from AcknowledgmentPicker.scssborder-radius: 25px; line from AcknowledgmentPicker.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this line wasn't important (I didn't notice any adverse changes when removing it), and it also solved my issue with the white border on the acknowledgment menu when in dark mode (mentioned here and here). Below is a video of the change.
React.Redux.App.-.Brave.2021-06-29.03-14-35.mp4
There is a bit of a white flash on the right side of the tapback picker when it is first opened, but I'm sure it won't be too hard to fix.