Made the dark mode acknowledgment picker a little less darker#46
Open
sabogalc wants to merge 3 commits intoopen-imcore:masterfrom
Open
Made the dark mode acknowledgment picker a little less darker#46sabogalc wants to merge 3 commits intoopen-imcore:masterfrom
sabogalc wants to merge 3 commits intoopen-imcore:masterfrom
Conversation
… of the acknowledgment menu more dark mode friendly
…mentPicker.scss`
sabogalc
added a commit
to sabogalc/imcore.react
that referenced
this pull request
Jun 29, 2021
…t, so now I'm undoing that mistake. My bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used a screenshot from my iPad to make this change
but seeing as the iOS and macOS dark modes are different, I can see this causing some conflicts. My next pull request (after fixing this one of course) will be changing dark mode to be more like iOS, but I can understand if that one is rejected seeing as this app is meant to emulate the macOS version.
This is the screenshot I will model my iOS dark mode off of.
