opentelemetry-sdk: add experimental composable rule based sampler #4882
+290
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Jan 20, 2026
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_rule_based.py
Outdated
Show resolved
Hide resolved
…mental/_rule_based.py Co-authored-by: Anuraag (Rag) Agrawal <anuraaga@gmail.com>
…t_description While at it also provide AttributePredicate
anuraaga
approved these changes
Jan 21, 2026
| def __str__(self) -> str: ... | ||
|
|
||
|
|
||
| class AttributePredicate: |
Contributor
There was a problem hiding this comment.
Did you mean to export this in __init__.py? Or otherwise probably better to move to the test
Contributor
Author
There was a problem hiding this comment.
Not sure I want to export this from __init__.py since this is not in the spec but I've seen java implements this (and isRoot) and can be handy for users I guess.
Contributor
There was a problem hiding this comment.
Right - just basically, if not exporting it, it could just be treated as a test helper instead of here I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a composable rule based sampler to the experimental samplers.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: