fix(ui): add missing aria-labels and alt attributes for better accessibility#3318
fix(ui): add missing aria-labels and alt attributes for better accessibility#3318NotxNoodles wants to merge 3 commits intoopenMF:devfrom
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note
|
| Cohort / File(s) | Summary |
|---|---|
Accessibility Attributes in Components src/app/groups/groups-view/groups-view.component.html, src/app/savings/savings-account-view/transactions-tab/transactions-tab.component.html, src/app/shared/theme-toggle/theme-toggle.component.html |
Added aria-label bindings with dynamic translation text and alt/role attributes. Theme toggle button aria-label switches between dark and light mode labels based on state. |
Translation Entries src/assets/translations/en-US.json |
Added three new translation keys: "Transaction Actions", "Switch to Dark Mode", and "Switch to Light Mode" to support aria-label bindings in components. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
- IOhacker
- alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title directly summarizes the main change: adding aria-labels and alt attributes for accessibility improvements across multiple components. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
alberto-art3ch
left a comment
There was a problem hiding this comment.
Please see my comment
| "Town / Village": "Town / Village", | ||
| "Trail ID": "Trail ID", | ||
| "Transaction": "Transaction", | ||
| "Transaction Actions": "Transaction Actions", |
There was a problem hiding this comment.
Please add the translation in the other languages
IOhacker
left a comment
There was a problem hiding this comment.
Pending Jira ticket and translation files
Added the 3 new translation keys introduced for accessibility improvements (Transaction Actions aria-label, Switch to Dark Mode, Switch to Light Mode) to all 12 non-English language files. English text is used as a fallback until native translations are contributed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace English fallback values with proper localized translations for the 3 accessibility keys (Transaction Actions, Switch to Dark Mode, Switch to Light Mode) across all 12 non-English language files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Description
Added missing
aria-labelattributes to icon-only buttons (theme toggle, transaction actions) andalttags to decorative profile images. This improves accessibility (a11y) and screen-reader compatibility across the application.Note: I am making this small contribution to familiarize myself with the Angular codebase and contribution workflow in preparation for my GSoC 2026 proposal for the MCP AI Assistant project!
Related issues and discussion
N/A - Spotted these missing attributes during a codebase review.
Screenshots, if any
N/A (These are underlying HTML attributes for screen readers, so there are no visual UI changes).
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit