ci: fix agy-acp binary artifact collision with source directory#988
Merged
Conversation
docker cp to a path that already exists as a directory copies the file INTO that directory instead of creating a file at that path. Since agy-acp/ is a source directory in the repo, the binary ended up at agy-acp/agy-acp and the artifact upload grabbed the whole directory. Fix by staging all binaries into .binaries/ before upload.
github-actions
Bot
added
the
closing-soon
|
All PRs must reference a prior Discord discussion to ensure community alignment before implementation. Please edit the PR description to include a link like: This PR will be automatically closed in 3 days if the link is not added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
build-binaryjob does:docker cp "$CID:/build/target/release/agy-acp" agy-acpBut
agy-acp/already exists as a source directory in the repo checkout. Whendocker cptargets a path that's already a directory, it copies the file into it asagy-acp/agy-acprather than creating a file at that path.Then
upload-artifactwithpath: agy-acpuploads the entire directory (source code + nested binary). On download to.pre-built/,agy-acpis a directory — not a binary. TheCOPY --from=adapter-buildersucceeds (copies a directory) butwhich agy-acpfails because it's not an executable file.This is why the antigravity smoke test fails with:
Fix
Stage all binaries into a dedicated
.binaries/directory before uploading, avoiding name collisions with any repo directories.Related