feat: add throttle controls for review gate#20
Open
yupoet wants to merge 3 commits intoopenai:mainfrom
Open
Conversation
The review gate can create long-running loops that drain usage limits quickly. This adds two new setup flags to control how often it fires: - --review-gate-max <n|off>: cap stop-gate reviews per session - --review-gate-cooldown <minutes|off>: minimum interval between reviews When a limit is hit, the gate is skipped (session allowed to end) and a note is logged. Manual /codex:review still works at any time. Co-Authored-By: yupoet <yupoet@users.noreply.github.com>
- Only count completed jobs toward session limit (not running/queued) - Require integer for --review-gate-cooldown (no fractional minutes) - Remove unused DEFAULT_* constants, inline null fallback - Add comment documenting sorted-input assumption on findLastStopReviewTime - Add 8 unit tests for checkThrottleLimits logic Co-Authored-By: yupoet <yupoet@users.noreply.github.com>
Collaborator
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: 8 files, +227 lines across 2 commits:
New flags:
Tests: 13 new tests all passing (5 config + 8 throttle logic)