app-server: persist conversation modalities + backfill on entry#11340
app-server: persist conversation modalities + backfill on entry#11340
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 817bf26c94
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| match read_summary_from_rollout(rollout_path.as_path(), fallback_provider) | ||
| .await | ||
| { |
There was a problem hiding this comment.
Avoid hard-failing on deferred rollout during thread start
This new read_summary_from_rollout call makes thread/start fail when the rollout file has not been materialized yet, but new sessions intentionally defer file creation until an explicit persist (the core rollout recorder documents this behavior, and record_initial_history for InitialHistory::New only flushes). In that case this branch returns an internal error even though the thread was already spawned, so clients see a failed start while a live thread remains in memory; the same pattern is also used in resume paths. Please fall back to snapshot-derived thread metadata when the rollout is not yet present instead of treating it as a fatal error.
Useful? React with 👍 / 👎.
a6de311 to
d58a4f8
Compare
d58a4f8 to
8db0700
Compare
Summary
Rationale
avoids repeated history scans.
Scope
Testing