-
Notifications
You must be signed in to change notification settings - Fork 7.9k
fix(network-proxy): add unix socket allow-all and update seatbelt rules #11368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c17717fc37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| validate( | ||
| config.network.dangerously_allow_all_unix_sockets, | ||
| move |candidate| match allow_all_unix_sockets { | ||
| Some(true) | None => Ok(()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disallow unix-socket override when managed flag is omitted
Treating constraints.dangerously_allow_all_unix_sockets == None as allowed means existing managed configs that only constrain network.allow_unix_sockets can now be bypassed by setting network.dangerously_allow_all_unix_sockets = true. In that case validation passes here, and is_unix_socket_allowed then returns true for any absolute path, so the managed allowlist is effectively unenforced unless every policy is updated to add the new field explicitly.
Useful? React with 👍 / 👎.
b6058f9 to
b9d540b
Compare
Summary
Adds support for a Unix socket escape hatch so we can bypass socket allowlisting when explicitly enabled.
Description
network.dangerously_allow_all_unix_socketsas an explicit escape hatch