Skip to content

Conversation

@viyatb-oai
Copy link
Collaborator

@viyatb-oai viyatb-oai commented Feb 10, 2026

Summary

Adds support for a Unix socket escape hatch so we can bypass socket allowlisting when explicitly enabled.

Description

  • added a new flag, network.dangerously_allow_all_unix_sockets as an explicit escape hatch
  • In codex-network-proxy, enabling that flag now allows any absolute Unix socket path from x-unix-socket instead of requiring each path to be explicitly allowlisted. Relative paths are still rejected.
  • updated the macOS seatbelt path in core so it enforces the same Unix socket behavior:
    • allowlisted sockets generate explicit network* subpath rules
    • allow-all generates a broad network* (subpath "/") rule

@viyatb-oai viyatb-oai marked this pull request as ready for review February 10, 2026 23:47
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c17717fc37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

validate(
config.network.dangerously_allow_all_unix_sockets,
move |candidate| match allow_all_unix_sockets {
Some(true) | None => Ok(()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Disallow unix-socket override when managed flag is omitted

Treating constraints.dangerously_allow_all_unix_sockets == None as allowed means existing managed configs that only constrain network.allow_unix_sockets can now be bypassed by setting network.dangerously_allow_all_unix_sockets = true. In that case validation passes here, and is_unix_socket_allowed then returns true for any absolute path, so the managed allowlist is effectively unenforced unless every policy is updated to add the new field explicitly.

Useful? React with 👍 / 👎.

@viyatb-oai viyatb-oai force-pushed the codex/viyatb/unix-socket-allow-all branch from b6058f9 to b9d540b Compare February 11, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants