Compact before sampling when switching to a smaller context model#11403
Closed
aibrahim-oai wants to merge 4 commits intostore-previous-turn-contextfrom
Closed
Compact before sampling when switching to a smaller context model#11403aibrahim-oai wants to merge 4 commits intostore-previous-turn-contextfrom
aibrahim-oai wants to merge 4 commits intostore-previous-turn-contextfrom
Conversation
Collaborator
aibrahim-oai
commented
Feb 11, 2026
aibrahim-oai
commented
- run pre-sampling compact when switching to a model with a smaller context window after usage crosses the new model limit.
- add e2e coverage for switch and resume+switch flows using 273k -> 125k context window models.
aibrahim-oai
changed the base branch from
main
to
store-previous-turn-context
pakrym-oai
reviewed
Feb 11, 2026
pakrym-oai
reviewed
Feb 11, 2026
|
|
||
| if run_pre_sampling_compact(&sess, &turn_context) | ||
| .await | ||
| .is_err() |
Collaborator
There was a problem hiding this comment.
surprised we return None here.
Collaborator
Author
There was a problem hiding this comment.
if error, we kill the loop with no final message. This was your request.
Collaborator
There was a problem hiding this comment.
My request was to kill the loop. Having the message seems fine.
Collaborator
Author
There was a problem hiding this comment.
but there is not message at this point though
pakrym-oai
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.