Add user-defined personalities and app-server personality listing by etraut-openai · Pull Request #16274 · openai/codex

etraut-openai · 2026-03-30T20:43:54Z

Summary

add support for loading user-defined personalities from .codex/personalities
merge built-in and file-backed personalities with validation, deduping, and startup-time discovery
add a personalities/list app-server RPC and update core, TUI, and Python SDK handling so custom personalities can be selected end to end

Testing

Not run (not requested)

etraut-openai · 2026-03-30T21:20:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fe56827b0e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

etraut-openai · 2026-03-30T21:54:06Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7dd638d3b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

codex-rs/core/src/personalities.rs

etraut-openai · 2026-03-30T22:20:39Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e66e16da07

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/personalities.rs

etraut-openai · 2026-03-31T02:24:38Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 79ade1242e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

codex-rs/app-server/src/codex_message_processor.rs

etraut-openai · 2026-03-31T04:09:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58d62412ad

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

codex-rs/app-server/src/codex_message_processor.rs

…lities # Conflicts: # codex-rs/core/src/state/service.rs # codex-rs/core/tests/common/test_codex.rs

rebroad · 2026-04-06T22:08:26Z

codex-rs/app-server-protocol/schema/typescript/ClientRequest.ts

 /**
 * Request from the client to the server.
 */
-export type ClientRequest ={ "method": "initialize", id: RequestId, params: InitializeParams, } | { "method": "thread/start", id: RequestId, params: ThreadStartParams, } | { "method": "thread/resume", id: RequestId, params: ThreadResumeParams, } | { "method": "thread/fork", id: RequestId, params: ThreadForkParams, } | { "method": "thread/archive", id: RequestId, params: ThreadArchiveParams, } | { "method": "thread/unsubscribe", id: RequestId, params: ThreadUnsubscribeParams, } | { "method": "thread/name/set", id: RequestId, params: ThreadSetNameParams, } | { "method": "thread/metadata/update", id: RequestId, params: ThreadMetadataUpdateParams, } | { "method": "thread/unarchive", id: RequestId, params: ThreadUnarchiveParams, } | { "method": "thread/compact/start", id: RequestId, params: ThreadCompactStartParams, } | { "method": "thread/shellCommand", id: RequestId, params: ThreadShellCommandParams, } | { "method": "thread/rollback", id: RequestId, params: ThreadRollbackParams, } | { "method": "thread/list", id: RequestId, params: ThreadListParams, } | { "method": "thread/loaded/list", id: RequestId, params: ThreadLoadedListParams, } | { "method": "thread/read", id: RequestId, params: ThreadReadParams, } | { "method": "skills/list", id: RequestId, params: SkillsListParams, } | { "method": "plugin/list", id: RequestId, params: PluginListParams, } | { "method": "plugin/read", id: RequestId, params: PluginReadParams, } | { "method": "app/list", id: RequestId, params: AppsListParams, } | { "method": "fs/readFile", id: RequestId, params: FsReadFileParams, } | { "method": "fs/writeFile", id: RequestId, params: FsWriteFileParams, } | { "method": "fs/createDirectory", id: RequestId, params: FsCreateDirectoryParams, } | { "method": "fs/getMetadata", id: RequestId, params: FsGetMetadataParams, } | { "method": "fs/readDirectory", id: RequestId, params: FsReadDirectoryParams, } | { "method": "fs/remove", id: RequestId, params: FsRemoveParams, } | { "method": "fs/copy", id: RequestId, params: FsCopyParams, } | { "method": "fs/watch", id: RequestId, params: FsWatchParams, } | { "method": "fs/unwatch", id: RequestId, params: FsUnwatchParams, } | { "method": "skills/config/write", id: RequestId, params: SkillsConfigWriteParams, } | { "method": "plugin/install", id: RequestId, params: PluginInstallParams, } | { "method": "plugin/uninstall", id: RequestId, params: PluginUninstallParams, } | { "method": "turn/start", id: RequestId, params: TurnStartParams, } | { "method": "turn/steer", id: RequestId, params: TurnSteerParams, } | { "method": "turn/interrupt", id: RequestId, params: TurnInterruptParams, } | { "method": "review/start", id: RequestId, params: ReviewStartParams, } | { "method": "model/list", id: RequestId, params: ModelListParams, } | { "method": "experimentalFeature/list", id: RequestId, params: ExperimentalFeatureListParams, } | { "method": "experimentalFeature/enablement/set", id: RequestId, params: ExperimentalFeatureEnablementSetParams, } | { "method": "mcpServer/oauth/login", id: RequestId, params: McpServerOauthLoginParams, } | { "method": "config/mcpServer/reload", id: RequestId, params: undefined, } | { "method": "mcpServerStatus/list", id: RequestId, params: ListMcpServerStatusParams, } | { "method": "windowsSandbox/setupStart", id: RequestId, params: WindowsSandboxSetupStartParams, } | { "method": "account/login/start", id: RequestId, params: LoginAccountParams, } | { "method": "account/login/cancel", id: RequestId, params: CancelLoginAccountParams, } | { "method": "account/logout", id: RequestId, params: undefined, } | { "method": "account/rateLimits/read", id: RequestId, params: undefined, } | { "method": "feedback/upload", id: RequestId, params: FeedbackUploadParams, } | { "method": "command/exec", id: RequestId, params: CommandExecParams, } | { "method": "command/exec/write", id: RequestId, params: CommandExecWriteParams, } | { "method": "command/exec/terminate", id: RequestId, params: CommandExecTerminateParams, } | { "method": "command/exec/resize", id: RequestId, params: CommandExecResizeParams, } | { "method": "config/read", id: RequestId, params: ConfigReadParams, } | { "method": "externalAgentConfig/detect", id: RequestId, params: ExternalAgentConfigDetectParams, } | { "method": "externalAgentConfig/import", id: RequestId, params: ExternalAgentConfigImportParams, } | { "method": "config/value/write", id: RequestId, params: ConfigValueWriteParams, } | { "method": "config/batchWrite", id: RequestId, params: ConfigBatchWriteParams, } | { "method": "configRequirements/read", id: RequestId, params: undefined, } | { "method": "account/read", id: RequestId, params: GetAccountParams, } | { "method": "getConversationSummary", id: RequestId, params: GetConversationSummaryParams, } | { "method": "gitDiffToRemote", id: RequestId, params: GitDiffToRemoteParams, } | { "method": "getAuthStatus", id: RequestId, params: GetAuthStatusParams, } | { "method": "fuzzyFileSearch", id: RequestId, params: FuzzyFileSearchParams, };


would be nice if this line was broken up into multiple lines - would make rebasing easier :)

etraut-openai added a commit that referenced this pull request Mar 30, 2026

codex: fix CI failure on PR #16274

315ca12

etraut-openai added a commit that referenced this pull request Mar 30, 2026

codex: shrink TUI test blob on PR #16274

fe56827

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

codex-rs/core/src/codex.rs Show resolved Hide resolved

etraut-openai added a commit that referenced this pull request Mar 30, 2026

codex: isolate core tests on PR #16274

04a1245

etraut-openai added a commit that referenced this pull request Mar 30, 2026

codex: address PR review feedback (#16274)

7dd638d

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

codex-rs/core/src/codex.rs Outdated Show resolved Hide resolved

codex-rs/core/src/personalities.rs Outdated Show resolved Hide resolved

etraut-openai added a commit that referenced this pull request Mar 30, 2026

codex: address PR review feedback (#16274)

e66e16d

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

codex-rs/core/src/personalities.rs Show resolved Hide resolved

etraut-openai added a commit that referenced this pull request Mar 30, 2026

codex: address PR review feedback (#16274)

ba43304

etraut-openai added a commit that referenced this pull request Mar 30, 2026

codex: fix core test config isolation on PR #16274

f7a8c24

chatgpt-codex-connector bot reviewed Mar 31, 2026

View reviewed changes

codex-rs/core/src/codex.rs Show resolved Hide resolved

codex-rs/app-server/src/codex_message_processor.rs Outdated Show resolved Hide resolved

etraut-openai added a commit that referenced this pull request Mar 31, 2026

codex: address PR review feedback (#16274)

58d6241

chatgpt-codex-connector bot reviewed Mar 31, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

codex-rs/app-server/src/codex_message_processor.rs Outdated Show resolved Hide resolved

etraut-openai added a commit that referenced this pull request Mar 31, 2026

codex: fix CI failure on PR #16274

defa9cf

etraut-openai added a commit that referenced this pull request Mar 31, 2026

codex: address PR review feedback (#16274)

80a6122

etraut-openai added a commit that referenced this pull request Mar 31, 2026

codex: fix blob-size-policy on PR #16274

b6daa2e

etraut-openai added a commit that referenced this pull request Mar 31, 2026

codex: shrink tui test blob on PR #16274

1f6e1d8

etraut-openai added a commit that referenced this pull request Mar 31, 2026

codex: fix CI failure on PR #16274

e021573

etraut-openai added a commit that referenced this pull request Mar 31, 2026

codex: fix CI failure on PR #16274

f5426f4

etraut-openai added a commit that referenced this pull request Mar 31, 2026

codex: revert Python SDK changes from PR #16274

f582f75

etraut-openai added 5 commits March 31, 2026 17:06

Add file-backed personality support and listing

8e00fec

codex: fix CI failure on PR #16274

a203d9d

codex: isolate core tests on PR #16274

7b6b29e

codex: address PR review feedback (#16274)

16f9414

codex: address PR review feedback (#16274)

c815040

etraut-openai added 12 commits March 31, 2026 17:08

codex: address PR review feedback (#16274)

5c70e25

codex: fix core test config isolation on PR #16274

f1a362d

codex: address PR review feedback (#16274)

3b0789c

codex: fix CI failure on PR #16274

e9d60db

codex: address PR review feedback (#16274)

ed678d5

codex: fix blob-size-policy on PR #16274

e765f83

codex: shrink tui test blob on PR #16274

8f9b44d

codex: fix CI failure on PR #16274

452d890

codex: fix CI failure on PR #16274

fd27ed0

Stabilize approval tests under Bazel

508c91c

codex: revert Python SDK changes from PR #16274

d6143dc

codex: fix rebase fallout on PR #16274

ece8f60

etraut-openai force-pushed the etraut/custom-personalities branch from f582f75 to ece8f60 Compare March 31, 2026 23:17

etraut-openai added 4 commits March 31, 2026 17:40

codex: fix personality popup snapshot on PR #16274

e669546

Merge branch 'main' into etraut/custom-personalities

aa13ea7

Merge remote-tracking branch 'origin/main' into etraut/custom-persona…

f325bb7

…lities # Conflicts: # codex-rs/core/src/state/service.rs # codex-rs/core/tests/common/test_codex.rs

Merge branch 'main' into etraut/custom-personalities

e525150

github-actions bot mentioned this pull request Apr 4, 2026

📊 AI CLI 工具社区动态日报 2026-04-04 gsscsd/big_model_radar#130

Open

rebroad reviewed Apr 6, 2026

View reviewed changes

etraut-openai closed this Apr 6, 2026

Conversation

etraut-openai commented Mar 30, 2026

Summary

Testing

Uh oh!

etraut-openai commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

etraut-openai commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

etraut-openai commented Mar 31, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

etraut-openai commented Mar 31, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

rebroad Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants