Fix TUI app-server permission profile conversions#16284
Merged
etraut-openai merged 4 commits intomainfrom Apr 2, 2026
Merged
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
etraut-openai
added a commit
that referenced
this pull request
Mar 31, 2026
etraut-openai
commented
Mar 31, 2026
etraut-openai
commented
Mar 31, 2026
etraut-openai
added a commit
that referenced
this pull request
Mar 31, 2026
etraut-openai
added a commit
that referenced
this pull request
Mar 31, 2026
etraut-openai
added a commit
that referenced
this pull request
Mar 31, 2026
etraut-openai
force-pushed
the
etraut/tui-permissions_regression
branch
from
c062e2a to
a2bab68
Compare
etraut-openai
added a commit
that referenced
this pull request
Mar 31, 2026
fcoury-oai
approved these changes
Apr 1, 2026
etraut-openai
force-pushed
the
etraut/tui-permissions_regression
branch
from
a2bab68 to
ef31767
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16283
Problem: TUI app-server permission approvals could drop filesystem grants because request and response payloads were round-tripped through mismatched camelCase and snake_case JSON shapes.
Solution: Replace the lossy JSON round-trips with typed app-server/core permission conversions so requested and granted permission profiles, including filesystem paths and scope, are preserved end to end.