Support model overrides for auto-review#23767
Open
won-openai wants to merge 6 commits into
Open
Conversation
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58f0201cf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some parent models need Guardian auto-review to run on the active parent model instead of the provider-preferred review model, while older
/modelspayloads still need to deserialize cleanly when they do not include the new catalog field.What changed
ModelInfo::auto_review_model_overridemetadata with omitted-field compatibility.Some(true)uses the parent turn model while missing or false values keep the existing preferred-review-model path and parent fallback.ModelInfoconstructors in local catalogs and fixtures for the new optional field.Validation
cargo test -p codex-protocolcargo test -p codex-core guardian_review_uses_ --libjust fmtjust fix -p codex-coregit diff --check origin/mainA full
cargo test -p codex-corerun compiled and progressed through the suite, then aborted with a stack overflow inthread_manager::tests::resume_and_fork_do_not_restore_thread_environments_from_rollout.