Skip to content

app-server: reload fork config on Windows#23769

Draft
aaronl-openai wants to merge 1 commit into
dev/aaronl/per-host-config---4iq5iwu8x2lp1ifrom
dev/aaronl/per-host-config---4iq5j-c67u0n13
Draft

app-server: reload fork config on Windows#23769
aaronl-openai wants to merge 1 commit into
dev/aaronl/per-host-config---4iq5iwu8x2lp1ifrom
dev/aaronl/per-host-config---4iq5j-c67u0n13

Conversation

@aaronl-openai
Copy link
Copy Markdown
Collaborator

@aaronl-openai aaronl-openai commented May 20, 2026

Overview

Keeps thread/fork aligned with current app-server config on Windows by removing the stale startup snapshot override instead of re-injecting old Windows sandbox state into forked threads. This PR is stacked on #23770.

Changes

  • Stop copying Windows sandbox mode from app-server startup config into fork request overrides.
  • Add a Windows-only regression proving a fork observes updated config.toml sandbox settings rather than startup state.
  • Leave a focused review note on detached review threads without changing that behavior in this patch.

Verification

  • Manually verified the stack with real codex app-server coverage for thread/fork host-config propagation.
  • Windows-specific fork re-resolution has dedicated regression coverage in this PR; CI is the platform run that exercises it.

git stack

@aaronl-openai aaronl-openai changed the base branch from dev/aaronl/per-host-config---4iq5iwu8x2lp1i to main May 20, 2026 22:39
@aaronl-openai aaronl-openai force-pushed the dev/aaronl/per-host-config---4iq5j-c67u0n13 branch from 6bc5ee4 to ef71c9a Compare May 20, 2026 22:39
@aaronl-openai aaronl-openai changed the base branch from main to dev/aaronl/per-host-config---4iq5iwu8x2lp1i May 20, 2026 22:39
git-stack-id: dev/aaronl/per-host-config---4iq5j-c67u0n13
git-stack-title: app-server: reload fork config on Windows
@aaronl-openai aaronl-openai changed the base branch from dev/aaronl/per-host-config---4iq5iwu8x2lp1i to main May 20, 2026 23:17
@aaronl-openai aaronl-openai force-pushed the dev/aaronl/per-host-config---4iq5j-c67u0n13 branch from ef71c9a to 2918f17 Compare May 20, 2026 23:17
@aaronl-openai aaronl-openai changed the base branch from main to dev/aaronl/per-host-config---4iq5iwu8x2lp1i May 20, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant