Add prompt-for-writes MCP tool approval mode#23778
Draft
kylepatel-oai wants to merge 1 commit into
Draft
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
4bff793 to
cd7627d
Compare
cd7627d to
5e86a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt_for_writesas a new MCP/app tool approval mode in config and app-server protocol schemas.read_only_hint == Some(true)skip approval; all other calls use the normal MCP approval elicitation and bypass Guardian auto-review.approval_mode = "approve"override.Notes
codex-appsgeneratedapp-server-typesin this PR: itsmcp-codegenscript currently uses the released dotslash Codex binary, while generating from this local runtime into a temp directory showed broad unrelated type churn. The runtime schema fixture here contains the newAppToolApprovalvalue for downstream consumption.Tests
CARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p codex-core mcp_tool_call_tests(matches 0 tests with this filter)CARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p codex-core mcp_tool_call::testsCARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p codex-core config_schemaCARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p codex-mcp prompt_for_writesCARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p codex-configCARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p codex-app-server-protocolCARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p codex-app-server config_manager_service_tests(matches 0 tests with this filter)CARGO_NET_GIT_FETCH_WITH_CLI=true cargo test -p codex-app-server write_value_supports