[codex] Exclude completed output from streamed Responses requests#23783
Draft
lancepereira-oai wants to merge 1 commit into
Draft
[codex] Exclude completed output from streamed Responses requests#23783lancepereira-oai wants to merge 1 commit into
lancepereira-oai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exclude: ["output"]on Codex's streamed Responses create requests.excludeentirely when it is empty so unrelated request shapes do not change.Why
Codex consumes streamed output items from incremental events and does not read terminal
response.completed.output, so the completed response payload is redundant for this path.Main Changes
Tests
cargo test -p codex-core build_responses_request_excludes_completed_outputcargo test -p codex-core omits_exclude_when_not_setcargo test -p codex-apiNotes
exclude, but the local CLI integration is currently blocked before request dispatch by this desktop config mismatch:approvals_reviewer = "auto_review"is rejected by this branch, which only acceptsuserorguardian_subagent.