Skip to content

sanitize invalid image history#23829

Draft
rhan-oai wants to merge 1 commit into
mainfrom
rhan/clean-images
Draft

sanitize invalid image history#23829
rhan-oai wants to merge 1 commit into
mainfrom
rhan/clean-images

Conversation

@rhan-oai
Copy link
Copy Markdown
Collaborator

Summary

  • map Responses invalid-image failures, including URL download failures, into InvalidImageRequest
  • replace bad user/tool images in conversation history with model-visible feedback instead of rolling back turns
  • let tool-output image failures continue sampling while user-supplied image failures surface a BadRequest error

Validation

  • cargo test -p codex-api api_bridge
  • cargo test -p codex-core replace_newest_images
  • cargo test -p codex-core invalid_user_image_is_sanitized_before_follow_up_turn
  • cargo test -p codex-core invalid_tool_image_is_replaced_and_returned_to_model
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant