Add Bedrock Mantle GovCloud region#23860
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0851846a5d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
recheck |
usgenes39-dotcom
left a comment
usgenes39-dotcom
left a comment
There was a problem hiding this comment.
I found one blocking provider-routing issue on the current head.
The GovCloud region itself is valid, but the base URL path this PR codifies is not. AWS documents the Mantle OpenAI-compatible base URL as https://bedrock-mantle.<region>.api.aws/v1, and a no-auth probe returns 401 for /v1/models but 404 for /openai/v1/models in both us-gov-west-1 and us-east-1. With this PR, users who select the newly supported GovCloud region will route Responses requests to /openai/v1/responses, so the region unlock still fails at request time. CI is green, but this should be fixed before merge.
| ); | ||
| assert_eq!( | ||
| base_url("us-gov-west-1").expect("supported region"), | ||
| "https://bedrock-mantle.us-gov-west-1.api.aws/openai/v1" |
There was a problem hiding this comment.
The new test locks in the wrong Mantle path for the newly added region. Current AWS docs set the OpenAI-compatible base URL to https://bedrock-mantle.<region>.api.aws/v1, and a no-auth probe confirms the path split: /v1/models returns 401 while /openai/v1/models returns 404 for us-gov-west-1 (and us-east-1 behaves the same). Since the API client appends /responses, this change enables the region but sends GovCloud traffic to /openai/v1/responses, which will fail before any billing/use can happen. Please switch the Mantle base URL generation and tests to /v1 before adding this region.
3 participants
Summary
Test