Skip to content

cli: remove legacy profile v1 plumbing#23886

Merged
jif-oai merged 3 commits into
mainfrom
jif/cleanup-CLI-profile-v1
May 21, 2026
Merged

cli: remove legacy profile v1 plumbing#23886
jif-oai merged 3 commits into
mainfrom
jif/cleanup-CLI-profile-v1

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented May 21, 2026

Why

#23883 moved the user-facing --profile flag onto profile v2. The shared CLI option layer still carried the old config_profile slot and several CLI entrypoints still copied that value into legacy config overrides. Leaving that path around makes the CLI surface look like it still selects legacy [profiles.*] state even though --profile now means $CODEX_HOME/<name>.config.toml.

What

  • Remove the legacy config_profile field and merge/copy path from SharedCliOptions.
  • Stop forwarding profile-v1 overrides from CLI, exec, TUI, doctor, debug, feature, and exec-server paths; runtime profile selection remains on config_profile_v2 through loader_overrides_for_profile.
  • Resolve local OSS provider selection from the base config in exec and TUI now that the legacy profile argument is gone.

Testing

@jif-oai jif-oai changed the title chore: clean CLI profile v1 cli: remove legacy profile v1 plumbing May 21, 2026
@jif-oai jif-oai merged commit e0e304b into main May 21, 2026
30 checks passed
@jif-oai jif-oai deleted the jif/cleanup-CLI-profile-v1 branch May 21, 2026 15:21
@github-actions github-actions Bot locked and limited conversation to collaborators May 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant