Skip to content

Complete Refactoring #2

Open
baugetfa wants to merge 16 commits intomasterfrom
release
Open

Complete Refactoring #2
baugetfa wants to merge 16 commits intomasterfrom
release

Conversation

@baugetfa
Copy link
Copy Markdown

  • added pyrpoject.toml
  • added meta.yaml and environment.yml
  • changed namespace to openalea.vmapplet
  • changed README.md

@Syl23 Syl23 requested review from Syl23 and pradal March 16, 2026 10:29
Comment thread conda/meta.yaml Outdated
{% set pyproject = load_file_data('../pyproject.toml', from_recipe_dir=True) %}
{% set name = pyproject.get('project').get('name') %}
{% set description = pyproject.get('project').get('description') %}
{% set version = environ.get('SETUPTOOLS_SCM_PRETEND_VERSION', "0.0.0.dev") %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start from the minimal published version rather than 0.0.0

Comment thread notebooks/simple_simulation.ipynb Outdated
"from pgljupyter import SceneWidget\n",
"from openalea import mtg\n",
"import vmapplet"
"from src.openalea import vmapplet"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works only in local computer.
Just import
from openalea import vmapplet

Comment thread pyproject.toml
# enable dynamic version based on git tags
[tool.setuptools_scm]
# Format version to ease alignment with conda/meta.yaml tag-based versioning
fallback_version = "0.1.0.dev0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this in sync with meta.yaml

Comment thread pyproject.toml Outdated
"xlrd",
"numpy",
"flake8",
"mypy",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mypy, black?
Not sure it is used

Comment thread README.md Outdated

### Institutes

CIRAD / inria
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add also INRAE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants