Fix: Model generation using oneOf, allOf & anyOf#1424
Open
egormanga wants to merge 1 commit intoopenapi-generators:mainfrom
Open
Fix: Model generation using oneOf, allOf & anyOf#1424egormanga wants to merge 1 commit intoopenapi-generators:mainfrom
oneOf, allOf & anyOf#1424egormanga wants to merge 1 commit intoopenapi-generators:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the JSON Schema spec, when a type definition has
oneOf,allOforanyOfvariation, the variant definition might contain only specific fields, rather than a complete type or reference:Currently, in such case the entire type fails to generate and gets treated as
Any, resulting in lacking validation.This implements the proper merging behavior, allowing to fully generate such types with their variants.
Additionally, replaces a relevant error-prone mutating operation, stumbled upon during debugging of this problem, with a non-mutating one due to unnecessity of the former.