You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@gzm0 Yes I can take this. I think it's a duplicate of a couple other issues, so I'll see about taking some time to gather the various bugs + fixes together to pick the best solution.
@Newbie012@gzm0@duncanbeevers@sultaniman This is a duplicate of this PR which was not yet merged; you can read the discussion there but the general idea I had is that we should avoid generating root types for enums when these flags are used together, instead of generating an exported type with Schema prefix just for enums, as it would be confusing. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openapi-tsRelevant to the openapi-typescript library
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
given the following settings:
the generated output will declare an enum and a type with the same name. This PR will avoid redeclaring a type if its node is an enum.
How to Review
The PR is quite minimal - code adjustment + a test
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)